rmcyang commented on code in PR #39725:
URL: https://github.com/apache/spark/pull/39725#discussion_r1086005947
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1356,6 +1356,17 @@ private boolean isTooLate(
!appShuffleMergePartitionsInfo.shuffleMergePartitions.containsKey(reduceId);
}
+ /**
+ * If necessary, look for the ignored bock bytes and capture them in
pushMergeMetrics.
+ */
+ private void lookForIgnoredBlockBytesIfNecessary() {
Review Comment:
Thanks for the suggestions, Chandni. Renamed it to
`updateIgnoredBytesWithDeferredBufs` based on the former, as it sounds more
smooth to me. Hopefully it looks better. Please let me know otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
