otterc commented on code in PR #39725:
URL: https://github.com/apache/spark/pull/39725#discussion_r1086238663
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1382,6 +1395,7 @@ public void onData(String streamId, ByteBuffer buf)
throws IOException {
freeDeferredBufs();
Review Comment:
When it comes here because of `isTooLateBlockPush` then the whole block is
going to be ignored. That means the deferredBufs which are getting freed will
be ignored as well so we need to add those bytes to the ignoreBlockBytes as
well, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
