itholic commented on code in PR #39705: URL: https://github.com/apache/spark/pull/39705#discussion_r1086438178
########## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ########## @@ -1749,29 +1749,30 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase { messageParameters = Map("dataType" -> field.dataType.catalogString)) } - def incompatibleViewSchemaChange( + def incompatibleViewSchemaChangeError( viewName: String, colName: String, expectedNum: Int, actualCols: Seq[Attribute], viewDDL: Option[String]): Throwable = { viewDDL.map { v => new AnalysisException( - errorClass = "_LEGACY_ERROR_TEMP_1176", + errorClass = "INCOMPATIBLE_VIEW_SCHEMA_CHANGE", messageParameters = Map( "viewName" -> viewName, "colName" -> colName, "expectedNum" -> expectedNum.toString, "actualCols" -> actualCols.map(_.name).mkString("[", ",", "]"), - "viewDDL" -> v)) + "suggestion" -> v)) }.getOrElse { new AnalysisException( - errorClass = "_LEGACY_ERROR_TEMP_1177", + errorClass = "INCOMPATIBLE_VIEW_SCHEMA_CHANGE", messageParameters = Map( "viewName" -> viewName, "colName" -> colName, "expectedNum" -> expectedNum.toString, - "actualCols" -> actualCols.map(_.name).mkString("[", ",", "]"))) + "actualCols" -> actualCols.map(_.name).mkString("[", ",", "]"), + "suggestion" -> "CREATE OR REPLACE TEMPORARY VIEW")) Review Comment: We can't get viewDDL for temporary view, but I think we can still suggest the basic command for users to guess the solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org