srielau commented on code in PR #39705:
URL: https://github.com/apache/spark/pull/39705#discussion_r1090984631
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -598,6 +598,29 @@
"Please try to re-create the view by running: <suggestion>."
]
},
+ "INCOMPLETE_TYPE_DEFINITION" : {
+ "message" : [
+ "Incomplete complex type:"
+ ],
+ "subClass" : {
+ "ARRAY" : {
+ "message" : [
+ "The definition of \"ARRAY\" type is incomplete. You must provide an
element type. For example: \"ARRAY<elementType>\"."
Review Comment:
```suggestion
"The definition of \"ARRAY\" type is incomplete. You must provide
an element type. For example: \"ARRAY<STRING>\"."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -598,6 +598,29 @@
"Please try to re-create the view by running: <suggestion>."
]
},
+ "INCOMPLETE_TYPE_DEFINITION" : {
+ "message" : [
+ "Incomplete complex type:"
+ ],
+ "subClass" : {
+ "ARRAY" : {
+ "message" : [
+ "The definition of \"ARRAY\" type is incomplete. You must provide an
element type. For example: \"ARRAY<elementType>\"."
+ ]
+ },
+ "MAP" : {
+ "message" : [
+ "The definition of \"MAP\" type is incomplete. You must provide a
key type and a value type. For example: \"MAP<TIMESTAMP, INT>\"."
+ ]
+ },
+ "STRUCT" : {
+ "message" : [
+ "The definition of \"STRUCT\" type is incomplete. You must provide
at least one field type. For example: \"STRUCT<Field1: INT>\"."
Review Comment:
Let's make the for examples more useful, also ':' is not needed and non SQL.
```suggestion
"The definition of \"STRUCT\" type is incomplete. You must provide
at least one field type. For example: \"STRUCT<name STRING, phone DECIMAL(10,
0)>\"."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
