NarekDW commented on code in PR #39723:
URL: https://github.com/apache/spark/pull/39723#discussion_r1096142932
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -2673,4 +2673,23 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
val indexes3 = jdbcTable.listIndexes()
assert(indexes3.isEmpty)
}
+
+ test("IDENTIFIER_TOO_MANY_NAME_PARTS: " +
Review Comment:
> Does the test improve the test coverage additionally to
QueryCompilationErrorsSuite.scala?
Yep, this test case tests `IdentifierHelper.asFunctionIdentifier` function,
but the test cases in the `QueryCompilationErrorsSuite ` test
`MultipartIdentifierHelper.asTableIdentifier` function only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
