NarekDW commented on code in PR #39723:
URL: https://github.com/apache/spark/pull/39723#discussion_r1096155322
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala:
##########
@@ -1119,4 +1119,32 @@ class V2SessionCatalogNamespaceSuite extends
V2SessionCatalogBaseSuite {
}
catalog.dropNamespace(testNs, cascade = false)
}
+
+ test("IdentifierHelper should throw exception when identifier has more than
2 parts") {
Review Comment:
`QueryCompilationErrorsSuite` - tests
`MultipartIdentifierHelper.asTableIdentifier`,
`JDBCV2Suite` - tests `IdentifierHelper.asFunctionIdentifier`
You are right there are some overlapping...
I've removed testing of these 2 functions from this file, left testing only
of `IdentifierHelper.asTableIdentifier` and
`MultipartIdentifierHelper.asFunctionIdentifier` functions, which is not
possible to reproduce from user side (sql)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
