smallzhongfeng commented on code in PR #39879:
URL: https://github.com/apache/spark/pull/39879#discussion_r1096617269
##########
core/src/main/scala/org/apache/spark/resource/ResourceAllocator.scala:
##########
@@ -38,11 +37,13 @@ private[spark] trait ResourceAllocator {
* For task resources ([[org.apache.spark.scheduler.ExecutorResourceInfo]]),
this value
* can be a multiple, such that each address can be allocated up to
[[slotsPerAddress]]
* times.
- *
- * TODO Use [[org.apache.spark.util.collection.OpenHashMap]] instead to gain
better performance.
*/
private lazy val addressAvailabilityMap = {
- mutable.HashMap(resourceAddresses.map(_ -> slotsPerAddress): _*)
+ val map: OpenHashMap[String, Int] = new OpenHashMap[String, Int]()
Review Comment:
So far, this TODO has not shown good performance after verification. Should
we remove it? @LuciferYang @srowen @dongjoon-hyun
And I tested the `getOrElse` method. Compared with the previous method, it
will reduce the time consumption by about% 4. Can I submit code on the current
pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
