srowen commented on code in PR #39879:
URL: https://github.com/apache/spark/pull/39879#discussion_r1096623501
##########
core/src/main/scala/org/apache/spark/resource/ResourceAllocator.scala:
##########
@@ -38,11 +37,13 @@ private[spark] trait ResourceAllocator {
* For task resources ([[org.apache.spark.scheduler.ExecutorResourceInfo]]),
this value
* can be a multiple, such that each address can be allocated up to
[[slotsPerAddress]]
* times.
- *
- * TODO Use [[org.apache.spark.util.collection.OpenHashMap]] instead to gain
better performance.
*/
private lazy val addressAvailabilityMap = {
- mutable.HashMap(resourceAddresses.map(_ -> slotsPerAddress): _*)
+ val map: OpenHashMap[String, Int] = new OpenHashMap[String, Int]()
Review Comment:
Yeah I would remove the TODO, and if that tiny optimization helps, then
let's just change this JIRA/PR to be about this little improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
