smallzhongfeng commented on code in PR #39962: URL: https://github.com/apache/spark/pull/39962#discussion_r1109403857
########## core/src/main/scala/org/apache/spark/scheduler/ExecutorDecommissionInfo.scala: ########## @@ -25,7 +25,19 @@ package org.apache.spark.scheduler * shuffle data might be lost even if the external shuffle service is enabled. */ private[spark] -case class ExecutorDecommissionInfo(message: String, workerHost: Option[String] = None) +abstract class DecommissionInfo + +private[spark] +case class ExecutorDecommissionInfo( Review Comment: Yes, how about `ExecutorTriggerExecutorDecommissionInfo` and `DriverTriggerExecutorDecommissionInfo`? Or could you give me a better opinion ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
