smallzhongfeng commented on code in PR #39962: URL: https://github.com/apache/spark/pull/39962#discussion_r1111057261
########## core/src/main/scala/org/apache/spark/scheduler/ExecutorDecommissionInfo.scala: ########## @@ -17,6 +17,9 @@ package org.apache.spark.scheduler +private[spark] +sealed abstract class DecommissionInfo Review Comment: It should not be necessary. After all, the case class here only needs to inherit this class `DecommissionInfo`. If the case class need multiple inheritance, it is more appropriate to use the trait here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
