amaliujia commented on code in PR #40109:
URL: https://github.com/apache/spark/pull/40109#discussion_r1114755349
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -128,7 +128,7 @@ message WriteOperationV2 {
// (Optional) A provider for the underlying output data source. Spark's
default catalog supports
// "parquet", "json", etc.
- string provider = 3;
+ optional string provider = 3;
Review Comment:
There is no need for `optional`. I believe if without `optional` on this
proto field, you can still tell if a field is set/unset.
If you can existing proto, `optional` is never used on any `(Optional)` field
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -128,7 +128,7 @@ message WriteOperationV2 {
// (Optional) A provider for the underlying output data source. Spark's
default catalog supports
// "parquet", "json", etc.
- string provider = 3;
+ optional string provider = 3;
Review Comment:
There is no need for `optional`. I believe even if without `optional` on
this proto field, you can still tell if a field is set/unset.
If you can existing proto, `optional` is never used on any `(Optional)` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
