ueshin commented on code in PR #40109:
URL: https://github.com/apache/spark/pull/40109#discussion_r1114763309
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -128,7 +128,7 @@ message WriteOperationV2 {
// (Optional) A provider for the underlying output data source. Spark's
default catalog supports
// "parquet", "json", etc.
- string provider = 3;
+ optional string provider = 3;
Review Comment:
Without `optional`, protobuf doesn't provide `hasXxx` method and we can't
check it's set/unset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
