hvanhovell commented on code in PR #40133:
URL: https://github.com/apache/spark/pull/40133#discussion_r1115216626
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -189,9 +245,54 @@ object SparkConnectClient {
}
def build(): SparkConnectClient = {
- val channelBuilder = ManagedChannelBuilder.forAddress(host,
port).usePlaintext()
- val channel: ManagedChannel = channelBuilder.build()
+ def insecureCredentials(): ChannelCredentials = {
+ InsecureChannelCredentials.create()
+ }
+ val creds = isSslEnabled match {
+ case None => insecureCredentials()
Review Comment:
NIT, you can combine cases, e.g.: `case None | Some(false) =>
insecureCredentials()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
