grundprinzip commented on code in PR #40133:
URL: https://github.com/apache/spark/pull/40133#discussion_r1116938358
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -117,6 +126,53 @@ object SparkConnectClient {
this
}
+ /**
+ * Setting the token implicitly sets the use_ssl=true. All the following
examples yield the
+ * same results:
+ *
+ * {{{
+ * sc://localhost/;token=aaa
+ * sc://localhost/;use_ssl=true;token=aaa
+ * sc://localhost/;token=aaa;use_ssl=true
+ * }}}
+ *
+ * Throws exception if the token is set but use_ssl=false.
+ *
+ * @param inputToken
+ * the user token.
+ * @return
+ * this builder.
+ */
+ def token(inputToken: String): Builder = {
+ require(inputToken != null && inputToken.nonEmpty)
+ token = Some(inputToken)
+ // Only set the isSSlEnabled if it is not yet set
+ isSslEnabled match {
+ case None => isSslEnabled = Some(true)
+ case Some(false) =>
+ throw new
IllegalArgumentException(AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG)
+ case Some(true) => // Good, the ssl is enabled
+ }
+ this
+ }
+
+ def enableSsl(): Builder = {
+ isSslEnabled = Some(true)
+ this
+ }
+
+ /**
+ * Disables the SSL. Throws exception if the token has been set.
+ *
+ * @return
+ * this builder.
+ */
+ def disableSsl(): Builder = {
+ require(token.isEmpty, AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG)
Review Comment:
No, from the Python GRPC implementation it basically says that you cannot
use a token on plaintext and we should follow this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
