zhengruifeng commented on PR #40097:
URL: https://github.com/apache/spark/pull/40097#issuecomment-1441536275
> > This PR also copies following testsuites to spark-mllib-common:
> > 1, org.apache.spark.ml.attribute.*
> > 2, org.apache.spark.ml.linalg.* except:
> > test("JavaTypeInference with VectorUDT") in VectorUDTSuite due to
cyclical dependency;
> > 3, org.apache.spark.ml.param.* except:
> > test("Filtering ParamMap") in ParamsSuite due to cyclical dependency;
>
> This is bad for code maintenance. Can we move these tests to a
"ml-common-test" jar, and in ml-client / ml-server tests they both run tests in
"ml-common-test" jar ?
let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
