dongjoon-hyun commented on code in PR #38823:
URL: https://github.com/apache/spark/pull/38823#discussion_r1116491490
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala:
##########
@@ -2717,4 +2717,21 @@ class DDLParserSuite extends AnalysisTest {
context = ExpectedContext(
fragment = "b STRING COMMENT \"abc\" NOT NULL COMMENT \"abc\"", start
= 27, stop = 71))
}
+
+ test("SPARK-41290: implement parser support for GENERATED ALWAYS AS columns
in tables") {
+ val schemaWithGeneratedColumn = new StructType()
+ .add("a", IntegerType, true)
+ .add("b", IntegerType, false,
+ new MetadataBuilder().putString("generationExpression", "a+1").build())
+ comparePlans(parsePlan(
+ "CREATE TABLE my_tab(a INT, b INT NOT NULL GENERATED ALWAYS AS (a+1))
USING parquet"),
Review Comment:
+1 for adding more negative test cases with `checkError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
