dongjoon-hyun commented on code in PR #38823: URL: https://github.com/apache/spark/pull/38823#discussion_r1116493655
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalogCapability.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import org.apache.spark.annotation.Evolving; + +/** + * Capabilities that can be provided by a {@link TableCatalog} implementation. + * <p> + * TableCatalogs use {@link TableCatalog#capabilities()} to return a set of capabilities. Each + * capability signals to Spark that the catalog supports a feature identified by the capability. + * For example, returning {@link #SUPPORTS_CREATE_TABLE_WITH_GENERATED_COLUMNS} allows Spark to + * accept {@code GENERATED ALWAYS AS} expressions in {@code CREATE TABLE} statements. + * + * @since 3.4.0 + */ +@Evolving +public enum TableCatalogCapability { + + /** + * Signals that the TableCatalog supports defining generated columns upon table creation in SQL. + * <p> + * Without this capability, any create/replace table statements with a generated column defined + * in the table schema will throw an exception during analysis. + * <p> + * A generated column is defined with syntax: {@code colName colType GENERATED ALWAYS AS (expr)} + * <p> + * Generation expression are included in the column definition for APIs like + * {@link TableCatalog#createTable}. + * See {@link Column#generationExpression()}. + */ + SUPPORTS_CREATE_TABLE_WITH_GENERATED_COLUMNS Review Comment: We use `2-space` indentation in Java files, don't we? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
