FurcyPin commented on code in PR #40271:
URL: https://github.com/apache/spark/pull/40271#discussion_r1126999170
##########
python/pyspark/sql/tests/test_functions.py:
##########
@@ -1268,6 +1268,12 @@ def test_bucket(self):
message_parameters={"arg_name": "numBuckets", "arg_type": "str"},
)
+ def test_no_cast(self):
Review Comment:
I apologize, but I am not sure I understand what you mean... it sounds like
you think that `functions.cast` already exists. It does not, there is only
`Column.cast`. This is what this test does: it checks that `functions.cast`
does not exists.
We _could_ add a `functions.cast` method, but I don't think we should
because
1. the need is already covered by `Column.cast`
2. that would require to add it to the Scala/Java API to be consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
