itholic commented on code in PR #40271: URL: https://github.com/apache/spark/pull/40271#discussion_r1127452614
########## python/pyspark/sql/tests/test_functions.py: ########## @@ -1268,6 +1268,12 @@ def test_bucket(self): message_parameters={"arg_name": "numBuckets", "arg_type": "str"}, ) + def test_no_cast(self): Review Comment: Oh,, yeah I thought we have `functions.cast`. Hmm... If `functions.cast` does not exist, I'm not sure if removing the duplication of `typing.cast` in advance would be appropriate. WDYT, @HyukjinKwon ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org