HyukjinKwon commented on code in PR #40270: URL: https://github.com/apache/spark/pull/40270#discussion_r1127647073
########## connector/connect/common/src/main/protobuf/spark/connect/relations.proto: ########## @@ -781,3 +782,10 @@ message FrameMap { CommonInlineUserDefinedFunction func = 2; } +message WithSequenceColumn { Review Comment: This PR adds just a protobuf message for the SQL plan that's internally used. I believe making it better is orthogonal in any event. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org