hvanhovell commented on code in PR #40270:
URL: https://github.com/apache/spark/pull/40270#discussion_r1127821694
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -781,3 +782,10 @@ message FrameMap {
CommonInlineUserDefinedFunction func = 2;
}
+message WithSequenceColumn {
Review Comment:
My main point is that we should not be polluting the protocol with something
that is essentially a projection.
What honestly makes things worse is, that the thing you are adding, is
subtilely broken. Once this is out in the open other implementations can and
generally will use it, and may run into the same bugs. We really have to be
prudent here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
