WeichenXu123 commented on code in PR #40297:
URL: https://github.com/apache/spark/pull/40297#discussion_r1133520106
##########
mllib/src/test/java/org/apache/spark/ml/param/JavaTestParams.java:
##########
@@ -108,9 +108,6 @@ private void init() {
myIntParam_ = new IntParam(this, "myIntParam", "this is an int param",
ParamValidators.gt(0));
myDoubleParam_ = new DoubleParam(this, "myDoubleParam", "this is a double
param",
ParamValidators.inRange(0.0, 1.0));
- List<String> validStrings = Arrays.asList("a", "b");
Review Comment:
When we have `T: ClassTag`, then java code cannot define the class like
`Param[XXX]`, java compiler cannot generate class tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
