WeichenXu123 commented on code in PR #40297:
URL: https://github.com/apache/spark/pull/40297#discussion_r1133666221
##########
mllib/src/main/scala/org/apache/spark/ml/param/params.scala:
##########
@@ -44,8 +45,14 @@ import org.apache.spark.ml.util.Identifiable
* See [[ParamValidators]] for factory methods for common
validation functions.
* @tparam T param value type
*/
-class Param[T](val parent: String, val name: String, val doc: String, val
isValid: T => Boolean)
- extends Serializable {
+class Param[T: ClassTag](
Review Comment:
@zhengruifeng
I recall I tried this approach `(implicit paramValueClassTag: ClassTag[T])`
before , but it make us hard to get the classTag object. So I prefer current
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
