pan3793 opened a new pull request, #40444:

   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines:
     2. Ensure you have added or run the appropriate tests for your PR:
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
     8. If you want to add or modify an error type or message, please read the 
guideline first in
   ### What changes were proposed in this pull request?
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   ### Why are the changes needed?
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   On K8s cluster mode, when 
   before [SPARK-35174](, the 
`spark-submit` will exit quickly w/ the basic application information.
   logInfo(s"Deployed Spark application ${conf.appName} with submission ID $sId 
into Kubernetes")
   After [SPARK-35174](, 
those part of code is unreachable, so nothing is output.
   This PR also proposes to change the `appName` to `appId` in the output 
message, to make it consistent w/ the context (if you look at the 
`LoggingPodStatusWatcherImpl`, this is kind of an exception, `... application 
$appId ...` is used in other places), and YARN.
   ### Does this PR introduce _any_ user-facing change?
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   Yes, changes contain
   1) when `spark.kubernetes.submission.waitAppCompletion=false`, the user can 
see the app information when `spark-submit` exit.
   2) the end of `spark-submit` information contains app id instead of app 
name, which is consistent w/ the context and other resource managers like YARN.
   ### How was this patch tested?
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions 
for the consistent environment, and the instructions could accord to:
   Pass CI.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to