pan3793 commented on code in PR #40444:
URL: https://github.com/apache/spark/pull/40444#discussion_r1137429300
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala:
##########
@@ -95,8 +95,8 @@ private[k8s] class LoggingPodStatusWatcherImpl(conf:
KubernetesDriverConf)
this.notifyAll()
}
- override def watchOrStop(sId: String): Boolean = if
(conf.get(WAIT_FOR_APP_COMPLETION)) {
- logInfo(s"Waiting for application ${conf.appName} with submission ID $sId
to finish...")
+ override def watchOrStop(sId: String): Boolean = {
+ logInfo(s"Waiting for application ${conf.appId} with submission ID $sId to
finish...")
Review Comment:
Sorry, I don't get your point, would you please elaborate more about the
risk?
IMO, this does not break
[SPARK-24266](https://issues.apache.org/jira/browse/SPARK-24266).
In the whole codebase except for the testing code, only one place invokes
`watchOrStop`
https://github.com/apache/spark/blob/8860f69455e5a722626194c4797b4b42cccd4510/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala#L183-L205
I claim it related to
[SPARK-35174](https://issues.apache.org/jira/browse/SPARK-35174) because after
[SPARK-35174](https://issues.apache.org/jira/browse/SPARK-35174),
`conf.get(WAIT_FOR_APP_COMPLETION)` is always `true`, then the change just like
```patch
- if (true) {
- logic1
- } else {
- logic2
- }
+ logic1
```
Please let me know if I misunderstand your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
