viirya commented on code in PR #40446: URL: https://github.com/apache/spark/pull/40446#discussion_r1138095296
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ########## @@ -864,6 +864,14 @@ object SQLConf { .checkValue(_ >= 0, "The maximum must not be negative") .createWithDefault(100) + val SUBEXPRESSION_ELIMINATION_SKIP_FOR_SHORTCUT_EXPR = + buildConf("spark.sql.subexpressionElimination.skipForShortcutExpr") + .internal() + .doc("When true, shortcut eliminate subexpression with `AND`, `OR`.") Review Comment: The description is very unclear. Can you add some more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org