Stove-hust commented on PR #40393: URL: https://github.com/apache/spark/pull/40393#issuecomment-1475528785
> @Stove-hust To clarify - I meant add this as well (after you had a chance to look at it and clean it up if required - this was from my test setup). We should keep the UT you had added - and it is important to test the specific code expectation as it stands today. Sorry, I misunderstood what you meant。😂 I think the UT written by you is great, can I write your UT in my PR, I will mark this part of UT written by you。 I have one more question, so for this PR we will have two UT, is that right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org