Stove-hust commented on PR #40393: URL: https://github.com/apache/spark/pull/40393#issuecomment-1475695975
> Technically, 3 :-) The UT that I added will generate 2 tests - one for push based shuffle and one without. And we have the initial test you added. > > You dont need to mark it as written by me ! We can include it in your PR - with any changes you make as part of the adding it. Thanks for your answer, I have added all three UTs (including you wrote) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org