dtenedor opened a new pull request, #40496:
URL: https://github.com/apache/spark/pull/40496

   ### What changes were proposed in this pull request?
   
   This PR enables the new golden file test framework for analysis for all 
input files.
   
   Background:
   * In https://github.com/apache/spark/pull/40449 we added the ability to 
exercise the analyzer on the SQL queries in existing golden files in the 
`sql/core/src/test/resources/sql-tests/inputs` directory, writing separate 
output test files in the new 
`sql/core/src/test/resources/sql-tests/analyzer-results` directory in 
additional to the original output directory for full end-to-end query execution 
results.
   * That PR also added an allowlist of input files to include in this new 
dual-run mode.
   * In this PR, we remove that allowlist exercise the new dual-run mode for 
all the input files. We also extend the analyzer testing to support separate 
test cases in ANSI-mode, TimestampNTZ, and UDFs.
   
   ### Why are the changes needed?
   
   This improves test coverage and helps prevent against accidental regressions 
in the future as we edit the code.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   This PR adds testing only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to