ulysses-you commented on code in PR #40446:
URL: https://github.com/apache/spark/pull/40446#discussion_r1142906959
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala:
##########
@@ -125,13 +128,27 @@ class EquivalentExpressions {
}
}
+ private def skipForShortcut(expr: Expression): Expression = {
+ if (skipForShortcutEnable) {
+ // The subexpression may not need to eval even if it appears more than
once.
+ // e.g., `if(or(a, and(b, b)))`, the expression `b` would be skipped if
`a` is true.
+ expr match {
+ case and: And => skipForShortcut(and.left)
Review Comment:
yea it is the fact, but after second though the `updateExprTree` has side
effect `updateExprInMap` during recursion. If we decide to skip for shortcut,
is it better to return the final valid expression in one shot ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
