amaliujia commented on code in PR #40498:
URL: https://github.com/apache/spark/pull/40498#discussion_r1142929171
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala:
##########
@@ -183,7 +183,7 @@ class DataFrameReader private[sql] (sparkSession:
SparkSession) extends Logging
dataSourceBuilder.setFormat(source)
userSpecifiedSchema.foreach(schema =>
dataSourceBuilder.setSchema(schema.toDDL))
extraOptions.foreach { case (k, v) =>
- dataSourceBuilder.putOptions(k, v)
+ builder.getReadBuilder.putOptions(k, v)
Review Comment:
I found I can only add a meaningful test in server side. On client sides
there is no way to verify an option has passed through.
In existing codebase, it is tested because we can do
`df.queryExecution.analyzed` then get the complete plan the to fetch the
options and verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
