ueshin commented on code in PR #40498:
URL: https://github.com/apache/spark/pull/40498#discussion_r1144066905
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -302,13 +302,16 @@ def plan(self, session: "SparkConnectClient") ->
proto.Relation:
class Read(LogicalPlan):
- def __init__(self, table_name: str) -> None:
+ def __init__(self, table_name: str, options: Dict[str, str] = {}) -> None:
Review Comment:
Please avoid `{}` as a default argument, which could cause unexpected
failures.
```py
def __init__(self, table_name: str, options: Optional[Dict[str, str]] =
None) -> None:
...
self.options = options or {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
