WeichenXu123 commented on code in PR #40520:
URL: https://github.com/apache/spark/pull/40520#discussion_r1144833150
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/MapInPandasExec.scala:
##########
@@ -28,7 +28,8 @@ import org.apache.spark.sql.execution.SparkPlan
case class MapInPandasExec(
func: Expression,
output: Seq[Attribute],
- child: SparkPlan)
+ child: SparkPlan,
+ override val isBarrier: Boolean)
Review Comment:
> change via Catalyst Optimizer (e.g., predicate pushdown)
Do you mean pushdown like this ?
```
Filter
MapInPandas
XXOp
....
```
to
```
MapInPandas
Filter
XXOp
....
```
?
I don't think we should allow pushdown in this case. `MapInPandas` executes
arbitrary user code. Can we modify optimizer code to prevent it change the plan
when it found "is_barrier" set ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
