HyukjinKwon commented on code in PR #40520:
URL: https://github.com/apache/spark/pull/40520#discussion_r1144848610
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/MapInPandasExec.scala:
##########
@@ -28,7 +28,8 @@ import org.apache.spark.sql.execution.SparkPlan
case class MapInPandasExec(
func: Expression,
output: Seq[Attribute],
- child: SparkPlan)
+ child: SparkPlan,
+ override val isBarrier: Boolean)
Review Comment:
I meant that the optimizers can might switch the physical plan order in the
future, and that's why the implementation is flaky. Now this works because we
don't switch the order anywhere else.
> Can we modify optimizer code to prevent it change the plan when it finds
"is_barrier" set ?
To have a complete implementation, we should have something like
https://github.com/apache/spark/pull/19873 which brought a lot of side effect,
and it got reverted in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
