zhenlineo commented on code in PR #40498: URL: https://github.com/apache/spark/pull/40498#discussion_r1145531822
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala: ########## @@ -458,7 +458,9 @@ class DataFrameReader private[sql] (sparkSession: SparkSession) extends Logging */ def table(tableName: String): DataFrame = { sparkSession.newDataFrame { builder => - builder.getReadBuilder.getNamedTableBuilder.setUnparsedIdentifier(tableName) + builder.getReadBuilder.getNamedTableBuilder + .setUnparsedIdentifier(tableName) + .putAllOptions(extraOptions.toMap.asJava) Review Comment: Can you add a simple golden file test to verify the table can take the opts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org