dtenedor commented on PR #40496: URL: https://github.com/apache/spark/pull/40496#issuecomment-1483097427
Sure, I can take a look. On Fri, Mar 24, 2023 at 3:12 AM Hyukjin Kwon ***@***.***> wrote: > I think ANSI test fails after this PR: > > [info] - timestampNTZ/datetime-special.sql_analyzer_test *** FAILED *** (31 milliseconds) > [info] timestampNTZ/datetime-special.sql_analyzer_test > [info] Expected "...date(999999, 3, 18, [false) AS make_date(999999, 3, 18)#x, make_date(-1, 1, 28, fals]e) AS make_date(-1, ...", but got "...date(999999, 3, 18, [true) AS make_date(999999, 3, 18)#x, make_date(-1, 1, 28, tru]e) AS make_date(-1, ..." Result did not match for query #1 > [info] select make_date(999999, 3, 18), make_date(-1, 1, 28) (SQLQueryTestSuite.scala:777) > [info] org.scalatest.exceptions.TestFailedException: > [info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472) > [info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471) > [info] at org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1564) > [info] at org.scalatest.Assertions.assertResult(Assertions.scala:847) > [info] at org.scalatest.Assertions.assertResult$(Assertions.scala:842) > [info] at org.scalatest.funsuite.AnyFunSuite.assertResult(AnyFunSuite.scala:1564) > [info] at org.apache.spark.sql.SQLQueryTestSuite.$anonfun$readGoldenFileAndCompareResults$3(SQLQueryTestSuite.scala:777) > [info] at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62) > > https://github.com/apache/spark/actions/runs/4496107425/jobs/7910457741 > > @dtenedor <https://github.com/dtenedor> mind taking a look please? cc > @gengliangwang <https://github.com/gengliangwang> > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/40496#issuecomment-1482557118>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AXU4PODW66JIEV5CNJWXEALW5VXQJANCNFSM6AAAAAAWBOMAJQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- Please write anonymous feedback for Daniel at any time (form <https://docs.google.com/forms/d/e/1FAIpQLSc-Nd9JOncZTMb2hlhj9GxQO0igStEBgtFclLXFsQleamA0ag/viewform?vc=0&c=0&w=1&flr=0> ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
