grundprinzip commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151047796
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -143,7 +170,13 @@ class SparkConnectService(debug: Boolean)
responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
try {
new SparkConnectStreamHandler(responseObserver).handle(request)
- } catch handleError("execute", observer = responseObserver)
+ } catch {
+ handleError(
+ "execute",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
user context should not be null, userid and session id can be null (but
should not). Better safe than sorry is my motto here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
