amaliujia commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151089716
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -143,7 +170,13 @@ class SparkConnectService(debug: Boolean)
responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
try {
new SparkConnectStreamHandler(responseObserver).handle(request)
- } catch handleError("execute", observer = responseObserver)
+ } catch {
+ handleError(
+ "execute",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
Do we need throw exceptions or assert? Assert might be proper if the `null`
stuff is due to developer errors which are expected to not happen and fixed as
bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
