dongjoon-hyun commented on code in PR #40589:
URL: https://github.com/apache/spark/pull/40589#discussion_r1153988178
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -111,11 +112,12 @@ class SparkSessionExtensions {
type FunctionDescription = (FunctionIdentifier, ExpressionInfo,
FunctionBuilder)
type TableFunctionDescription = (FunctionIdentifier, ExpressionInfo,
TableFunctionBuilder)
type ColumnarRuleBuilder = SparkSession => ColumnarRule
- type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan]
+ type QueryStageRuleBuilder = SparkSession => Rule[SparkPlan]
private[this] val columnarRuleBuilders =
mutable.Buffer.empty[ColumnarRuleBuilder]
- private[this] val queryStagePrepRuleBuilders =
mutable.Buffer.empty[QueryStagePrepRuleBuilder]
+ private[this] val queryStagePrepRuleBuilders =
mutable.Buffer.empty[QueryStageRuleBuilder]
private[this] val runtimeOptimizerRules = mutable.Buffer.empty[RuleBuilder]
+ private[this] val queryStageOptimizerBuildersRules =
mutable.Buffer.empty[QueryStageRuleBuilder]
Review Comment:
It's a little strange because of two plural words, `BuildersRules`. Is there
any reason why we use ``queryStageOptimizerBuildersRules` instead of
`queryStageOptimizerBuilders`?
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -111,11 +112,12 @@ class SparkSessionExtensions {
type FunctionDescription = (FunctionIdentifier, ExpressionInfo,
FunctionBuilder)
type TableFunctionDescription = (FunctionIdentifier, ExpressionInfo,
TableFunctionBuilder)
type ColumnarRuleBuilder = SparkSession => ColumnarRule
- type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan]
+ type QueryStageRuleBuilder = SparkSession => Rule[SparkPlan]
private[this] val columnarRuleBuilders =
mutable.Buffer.empty[ColumnarRuleBuilder]
- private[this] val queryStagePrepRuleBuilders =
mutable.Buffer.empty[QueryStagePrepRuleBuilder]
+ private[this] val queryStagePrepRuleBuilders =
mutable.Buffer.empty[QueryStageRuleBuilder]
private[this] val runtimeOptimizerRules = mutable.Buffer.empty[RuleBuilder]
+ private[this] val queryStageOptimizerBuildersRules =
mutable.Buffer.empty[QueryStageRuleBuilder]
Review Comment:
It's a little strange because of two plural words, `BuildersRules`. Is there
any reason why we use `queryStageOptimizerBuildersRules` instead of
`queryStageOptimizerBuilders`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
