dongjoon-hyun commented on code in PR #40589:
URL: https://github.com/apache/spark/pull/40589#discussion_r1153989800
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -111,11 +112,12 @@ class SparkSessionExtensions {
type FunctionDescription = (FunctionIdentifier, ExpressionInfo,
FunctionBuilder)
type TableFunctionDescription = (FunctionIdentifier, ExpressionInfo,
TableFunctionBuilder)
type ColumnarRuleBuilder = SparkSession => ColumnarRule
- type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan]
+ type QueryStageRuleBuilder = SparkSession => Rule[SparkPlan]
Review Comment:
- Although `QueryStagePrepRuleBuilder` and `QueryStageRuleBuilder` types has
identical types for now, do we need to merge like this?
- Why don't we keep the existing `QueryStagePrepRuleBuilder` in the AS-IS
status and add `QueryStageRuleBuilder` newly? Then, we can change both types
independently in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
