LuciferYang commented on code in PR #40564:
URL: https://github.com/apache/spark/pull/40564#discussion_r1155074951
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -57,6 +57,15 @@ object IntegrationTestUtils {
Files.exists(Paths.get(filePath))
}
+ private[sql] lazy val isCatalystTestJarAvailable: Boolean = {
Review Comment:
I test the following scenarios:
1. build/sbt clean "connect-client-jvm/test"
2. build/sbt clean "connect-client-jvm/testOnly *ClientE2ETestSuite"
3.
```
build/mvn clean
build/mvn clean package test -Dtest=none
-DwildcardSuites=org.apache.spark.sql.ClientE2ETestSuite
```
4.
```
build/mvn clean
build/mvn clean install -pl connector/connect/server -am -DskipTests
build/mvn clean install -pl assembly -DskipTests
build/mvn clean test -pl connector/connect/client/jvm
```
New tests can be triggered and tested successfully.
@Hisoka-X So haver you thought of any other way to successfully test before
this PR, but without `isCatalystTestJarAvailable ` checking, the test will fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
