LuciferYang commented on code in PR #40564:
URL: https://github.com/apache/spark/pull/40564#discussion_r1155077877
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -670,6 +738,7 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper {
bean.setValue(v)
bean
}
+
Review Comment:
This seems unrelated to the current pr, please revert this blank line
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala:
##########
@@ -434,7 +433,9 @@ abstract class InMemoryBaseTable(
protected var streamingWriter: StreamingWrite = StreamingAppend
override def overwriteDynamicPartitions(): WriteBuilder = {
- assert(writer == Append)
+ if (writer != Append) {
Review Comment:
make sense
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -801,7 +870,9 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper {
}
private[sql] case class MyType(id: Long, a: Double, b: Double)
+
Review Comment:
ditto
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -801,7 +870,9 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper {
}
private[sql] case class MyType(id: Long, a: Double, b: Double)
+
private[sql] case class KV(key: String, value: Int)
+
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
