grundprinzip commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1156651960
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -53,11 +53,8 @@ message SqlCommand {
// (Required) SQL Query.
string sql = 1;
- // (Optional) A map of parameter names to string values that are parsed as
- // SQL literal expressions. For example, map keys: "rank", "name",
"birthdate";
- // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string
values
- // belonged to SQL comments are skipped while parsing.
- map<string, string> args = 2;
+ // (Optional) A map of parameter names to literal expressions.
+ map<string, Expression.Literal> args = 2;
Review Comment:
would be valid:
```suggestion
map<string, string> args = 2;
map<string, Expression.Literal> expr_args = 3;
```
so might be
```suggestion
oneof args {
map<string, string> args = 2;
map<string, Expression.Literal> expr_args = 3;
}
```
Please run
```
buf breaking --against
"https://github.com/apache/spark/archive/master.zip#strip_components=1,subdir=connector/connect/common/src/main";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
