mridulm commented on code in PR #40663:
URL: https://github.com/apache/spark/pull/40663#discussion_r1159157778
##########
core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala:
##########
@@ -262,13 +263,16 @@ class TaskMetrics private[spark] () extends Serializable {
/**
* External accumulators registered with this task.
*/
- @transient private[spark] lazy val externalAccums = new
ArrayBuffer[AccumulatorV2[_, _]]
+ @transient private[spark] lazy val _externalAccums = new
CopyOnWriteArrayList[AccumulatorV2[_, _]]
+
+ private[spark] def externalAccums() = _externalAccums.asScala
Review Comment:
nit: drop the `()`
##########
core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala:
##########
@@ -262,13 +263,16 @@ class TaskMetrics private[spark] () extends Serializable {
/**
* External accumulators registered with this task.
*/
- @transient private[spark] lazy val externalAccums = new
ArrayBuffer[AccumulatorV2[_, _]]
+ @transient private[spark] lazy val _externalAccums = new
CopyOnWriteArrayList[AccumulatorV2[_, _]]
+
+ private[spark] def externalAccums() = _externalAccums.asScala
private[spark] def registerAccumulator(a: AccumulatorV2[_, _]): Unit = {
- externalAccums += a
+ _externalAccums.add(a)
}
- private[spark] def accumulators(): Seq[AccumulatorV2[_, _]] = internalAccums
++ externalAccums
+ private[spark] def accumulators(): Seq[AccumulatorV2[_, _]] =
+ internalAccums ++ _externalAccums.asScala
Review Comment:
nit: revert ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
