LuciferYang commented on code in PR #40663:
URL: https://github.com/apache/spark/pull/40663#discussion_r1159418688


##########
core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala:
##########
@@ -270,6 +272,28 @@ class ExecutorSuite extends SparkFunSuite
     heartbeatZeroAccumulatorUpdateTest(false)
   }
 
+  test("SPARK-39696: Using accumulators should not cause heartbeat to fail") {
+    val conf = new SparkConf().setMaster("local").setAppName("executor suite 
test")
+    conf.set(EXECUTOR_HEARTBEAT_INTERVAL.key, "1ms")
+    sc = new SparkContext(conf)
+
+    val accums = (1 to 10).map(i => 
sc.longAccumulator(s"mapperRunAccumulator${i}"))
+    val input = sc.parallelize(1 to 10, 10)
+    val baseRdd = input.map(i => (i, i))
+    var testRdd = baseRdd

Review Comment:
   Need to assign `baseRdd` to `testRdd`?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to