cloud-fan commented on code in PR #40651:
URL: https://github.com/apache/spark/pull/40651#discussion_r1159727971
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -154,12 +155,7 @@ abstract class PercentileBase
return Seq.empty
}
- val ordering = child.dataType match {
- case numericType: NumericType => numericType.ordering
- case intervalType: YearMonthIntervalType => intervalType.ordering
- case intervalType: DayTimeIntervalType => intervalType.ordering
- case otherType => QueryExecutionErrors.unsupportedTypeError(otherType)
- }
+ val ordering = PhysicalDataType.ordering(child.dataType)
Review Comment:
does any place need `Ordering[InternalType]`? if not we can always return
`Ordering[Any]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
