hvanhovell commented on code in PR #40651:
URL: https://github.com/apache/spark/pull/40651#discussion_r1160375619
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala:
##########
@@ -56,21 +57,12 @@ class InterpretedOrdering(ordering: Seq[SortOrder]) extends
BaseOrdering {
} else if (right == null) {
return if (order.nullOrdering == NullsFirst) 1 else -1
} else {
+ val orderingFunc =
physicalDataTypes(i).ordering.asInstanceOf[Ordering[Any]]
val comparison = order.dataType match {
Review Comment:
You don't need this match anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
