hvanhovell commented on code in PR #40684:
URL: https://github.com/apache/spark/pull/40684#discussion_r1159876187
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1624,6 +1626,12 @@ class Dataset[T] private[sql] (
}
}
+ private def withDataset(other: Dataset[_]): Unit = {
+ assert(
Review Comment:
Asserts can be elided. Can you just add and if statement here, and throw a
proper exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
