HyukjinKwon commented on code in PR #40684:
URL: https://github.com/apache/spark/pull/40684#discussion_r1160370564
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:
##########
@@ -49,7 +49,7 @@ import org.apache.spark.util.Utils
object SparkConnectServerUtils {
// Server port
- private[connect] val port = ConnectCommon.CONNECT_GRPC_BINDING_PORT +
util.Random.nextInt(1000)
+ val port: Int = ConnectCommon.CONNECT_GRPC_BINDING_PORT +
util.Random.nextInt(1000)
Review Comment:
Can we use a ephemeral port to make sure on the test flakiness? See also
`SparkConnectService.localPort`, and
https://github.com/apache/spark/blob/c7007b37e15ed1dc7c27e44576aa21f2e9e10e3f/python/pyspark/sql/connect/session.py#L503-L506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
