wankunde commented on code in PR #40523:
URL: https://github.com/apache/spark/pull/40523#discussion_r1160439594
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/JoinCodegenSupport.scala:
##########
@@ -95,4 +95,27 @@ trait JoinCodegenSupport extends CodegenSupport with
BaseJoinExec {
}
}
}
+
+ /**
+ * Splits variables based on whether it's used by condition or not, returns
the code to create
Review Comment:
Yes, move `splitVarsByCondition` method into JoinCodegenSupport, so it can
be used in ShuffledHashJoinExec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
